Fix/empty labelselector #22
Open
+57
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Collaborator
|
looks like CI got stuck, I'll try closing and reopening this PR. |
Author
|
sorry. did not notice the complexity lint error. I will try to fix it later. |
…exity for golangci-lint Signed-off-by: Tim <[email protected]>
Signed-off-by: Tim <[email protected]>
Author
|
@phisco this should do it. my version of golangci-lint also detected a dangerous kind of integer conversion which I also fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently the function does NOT request a resource when a fieldPath was specified as optional and no other labels have been chosen.
This specifically intended behaviour is kept and a flag is added which tracks if optional fields were not found.
If not the matchLabels is added even if it is empty.
Also an appropriate test was added
Fixes #21
I have: