Skip to content

Check for updates on base image during build #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bltavares
Copy link

@bltavares bltavares commented Mar 21, 2019

It is important to keep Docker images up-to date, as upstream images
could have important security fixes, even using the same tag and
version.

When building images, it is possible to pass in a --pull flag to check
if the base image has updates, and rebuild as necessary. This feature is
available since 2014, and will still retain the image cache if there are
no updates on the base image.

Travis might need updated Docker version. It is documented how to update it on their docs if it becomes necessary.

It is important to keep Docker images up-to date, as upstream images
could have important security fixes, even using the same tag and
version.

When building images, it is possible to pass in a `--pull` flag to check
if the base image has updates, and rebuild as necessary. This feature is
available since 2014, and will still retain the image cache if there are
no updates on the base image.

[since 2014]: moby/moby#9281
@bltavares bltavares requested review from Dylan-DPC-zz, jamesmunns and a team as code owners March 21, 2019 19:17
@bltavares
Copy link
Author

The images have been quite outdated, and while developing a GitHub Action similar to goreleaser, I've noticed that last Travis run has been 1 year ago.

There has been a recent commit on master this year, in January, which didn't trigger new updates. This could be likely due to the change on user host the code, and Travis not being properly configured for the new rust-embedded user.

I've also noticed that this project has changed maintainers, but the images still live under the previous Docker Hub account. I would be able to help change the code to point to the new user on Docker Hub, but I can't help with credential management and setup of Travis.

There are other issues (eg: #261) that have noticed the missing image as well. How could I help to make new images available?

@Dylan-DPC-zz
Copy link

Thanks

bors: try

bors bot added a commit that referenced this pull request Mar 21, 2019
@bors
Copy link
Contributor

bors bot commented Mar 21, 2019

try

Build failed

A couple of packages were not available anymore on Debian Package repository.
This commit updates the names and version in order to fix the image building process
@bltavares
Copy link
Author

Some images had outdated packages not available on Debian repository anymore. I've pointed to existing packages on a follow up commit on this PR, in case you want to retry building it.

Compiling recent Rust code requires 'libc6' at least 2.18. This commit updates the version to point to a newer linux wich contains libc6 2.19 by default.
@Dylan-DPC-zz
Copy link

bors: try

bors bot added a commit that referenced this pull request Mar 28, 2019
@bors
Copy link
Contributor

bors bot commented Mar 29, 2019

try

Build failed

@bltavares
Copy link
Author

I think it will be necessary to change the url of Dropbear to point to their new releases path.
I could take a look later this week.

The path has changed, and the previous path only had the current release. This commit points it to the new releases directory on the main website
@bltavares
Copy link
Author

@Dylan-DPC would you mind trying again? I've updated the url for dropbear instalation

@Dylan-DPC-zz
Copy link

@bltavares sure. some of the builds are failing due to a unrelated issue. Will still try this

bors: try

bors bot added a commit that referenced this pull request Apr 1, 2019
@bors
Copy link
Contributor

bors bot commented Apr 1, 2019

try

Build failed

@mathk mathk added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2019
Copy link
Contributor

@spl spl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're fixing some typos, you might as well fix the others on the same lines. 🙂 Not that important, of course.

Thanks for noticing them

Co-Authored-By: Sean Leather <[email protected]>
@reitermarkus
Copy link
Member

Most of these changes are now in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants