Stop hard-coding NEON support for armv7-unknown-linux-musleabihf. #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #252. Signed-off-by: Brian Smith <[email protected]>
briansmith
requested review from
Dylan-DPC-zz,
jamesmunns and
a team
as code owners
|
Note: I didn't test this on a device or emulator without NEON support. |
|
bors try Thanks @briansmith! |
|
We should consider whether we need to make any changes like what was done in https://github.com/rust-lang/rust/pull/56725/files along with this. Thoughts? |
tryBuild failed |
|
bors: try |
tryBuild failed |
Disasm
added
T-tools
S-blocked
This was referenced Feb 26, 2019
reitermarkus
approved these changes
Aug 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 25, 2019
255: Stop hard-coding NEON support for armv7-unknown-linux-musleabihf. r=reitermarkus a=briansmith Fixes #252. Signed-off-by: Brian Smith <[email protected]> Co-authored-by: Brian Smith <[email protected]>
reitermarkus
removed
the
S-blocked
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252.
Signed-off-by: Brian Smith [email protected]