Skip to content

feat: add riscv64gc-unknown-linux-musl image #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025
Merged

Conversation

a-wing
Copy link
Contributor

@a-wing a-wing commented Apr 12, 2025

Close #1197


Only use crosstools-ng

If use musl-cross-make, binutils version is to low too ld cannot link in riscv

I test musl.cc riscv64-linux-musl-cross.tgz, It's ok binutils: 2.37, ld can link, It's working

But, musl-cross-make is only support binutils: 2.33.1, binutils: 2.33.2 is big changed, The patch is unavailable, migration this patch is very complex (a lot of conflict). BTW: These patches have nothing to do with riscv

@a-wing a-wing requested a review from a team as a code owner April 12, 2025 00:01
@Emilgardis
Copy link
Member

/ci try --target riscv64gc-unknown-linux-musl

This comment has been minimized.

This comment has been minimized.

@Emilgardis
Copy link
Member

/ci try --target riscv64gc-unknown-linux-musl

This comment has been minimized.

Copy link

Try run for comment

Successful Jobs

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :)

@Emilgardis Emilgardis added this pull request to the merge queue Apr 12, 2025
@Emilgardis Emilgardis added the CI-riscv64gc-unknown-linux-musl Run CI for riscv64gc-unknown-linux-musl target label Apr 12, 2025
@Emilgardis Emilgardis removed this pull request from the merge queue due to a manual request Apr 12, 2025
@Emilgardis Emilgardis added this pull request to the merge queue Apr 12, 2025
Merged via the queue into cross-rs:main with commit 26fea07 Apr 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-riscv64gc-unknown-linux-musl Run CI for riscv64gc-unknown-linux-musl target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: support for riscv64-unknown-linux-musl
2 participants