Skip to content

Commit

Permalink
Bump python version on windows to see if vc is bumped
Browse files Browse the repository at this point in the history
Disable error when version regex not set
  • Loading branch information
langmm committed May 23, 2024
1 parent 9ac53e0 commit fa4640a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ jobs:
- macos
- windows
python-version:
- 3.8
- 3.9
test-flags1:
- long-mpi
test-flags2:
Expand Down
2 changes: 1 addition & 1 deletion utils/test-install-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ jobs:
max-parallel: 20
matrix:
os-base: [ubuntu, macos, windows]
python-version: [3.8]
python-version: [3.9] # TODO: propertly update the base version
install-method: [conda]
test-flags1: [long-mpi]
test-flags2: [examples-backwards]
Expand Down
2 changes: 2 additions & 0 deletions yggdrasil/drivers/CModelDriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,8 @@ class ARArchiver(ArchiverBase):
output_key = ''
output_first_library = True
toolset = 'gnu'
version_regex = [
r'(?P<version>GNU ar version \d+\.\d+\.\d+(?:\-[\.0-9a-zA-Z]+)?)']
compatible_toolsets = ['llvm']
search_path_envvar = ['LIBRARY_PATH']

Expand Down
7 changes: 4 additions & 3 deletions yggdrasil/drivers/CompiledModelDriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -5003,9 +5003,10 @@ def extract_tool_version(cls, x, require_match=False):
f"Could not locate version in string: {x} with "
f"regex {cls.version_regex}")
if x and require_match:
raise Exception(f"{cls}: {cls.tooltype.title()} "
f"{cls.toolname} does not have a "
f"version regex")
# raise Exception(f"{cls}: {cls.tooltype.title()} "
# f"{cls.toolname} does not have a "
# f"version regex")
return ''
return x

@staticmethod
Expand Down
2 changes: 1 addition & 1 deletion yggdrasil/drivers/MakeModelDriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class MakeBuilder(BuilderBase):
[('buildfile', {'key': '-f', 'position': 0})])
output_key = None
build_params = ['target']
version_regex = r'(?P<version>GNU Make \d+\.\d+(?:\.\d+)?)'
version_regex = [r'(?P<version>GNU Make \d+\.\d+(?:\.\d+)?)']

@classmethod
def get_flags(cls, target=None, **kwargs):
Expand Down

0 comments on commit fa4640a

Please sign in to comment.