Skip to content

Commit

Permalink
Fix bug introduced by always including libraries
Browse files Browse the repository at this point in the history
  • Loading branch information
langmm committed May 28, 2024
1 parent 3aab877 commit 0a51fd1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions yggdrasil/drivers/CMakeModelDriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -880,8 +880,7 @@ def create_exports(cls, dep, products=None, overwrite=False,
f'{dep.name}{suffix}Targets.cmake')
dependencies = dep.dependency_order()
dep_kws = {'dry_run': True}
dependencies.getall('dep_kwargs', to_update=dep_kws,
dep_libtype=dep['libtype'])
dependencies.getall('dep_kwargs', to_update=dep_kws)
if dep.result in dep_kws.get('libraries', []):
dep_kws['libraries'].remove(dep.result)
lines = [
Expand Down
3 changes: 2 additions & 1 deletion yggdrasil/drivers/CompiledModelDriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -3474,7 +3474,8 @@ def _dep_libtool_kwargs(self, key, to_update=None, dep_libtype=None,
if not os.path.isfile(dep_lib):
raise RuntimeError(f"Library for {self.name} dependency "
f"does not exist: '{dep_lib}'.")
if self['libtype'] in self.library_files:
if ((self['libtype'] in self.library_files
and dep_libtype != 'static')):
libkey = 'libraries'
if use_library_path_internal and self.origin == 'internal':
if to_update.get('skip_library_libs', False):
Expand Down

0 comments on commit 0a51fd1

Please sign in to comment.