Skip to content

Conversation

jscheid
Copy link

@jscheid jscheid commented Oct 8, 2025

What this does

Allows passing Aws::CredentialProvider objects (instance profile, assume role, etc.) instead of static credentials. Provider takes precedence when both are configured. This is a solution to the problem of authenticating with e.g. role-based permissions, as discussed here.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
    • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
    • All tests pass: bundle exec rspec
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

Related issues

Related to #16

Allows passing Aws::CredentialProvider objects (instance profile,
assume role, etc.) instead of static credentials. Provider takes
precedence when both are configured.
@jscheid
Copy link
Author

jscheid commented Oct 8, 2025

@tpaulshippy here's a PR as discussed, please let me know what you think?

@tpaulshippy
Copy link
Contributor

Looks great! Much nicer than the approach I'm using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants