Allow use new capabilities when use assume_exists #350
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crmne
requested changes
Aug 15, 2025
| @@ -66,7 +66,7 @@ def resolve(model_id, provider: nil, assume_exists: false, config: nil) # ruboco | |||
| id: model_id, | |||
| name: model_id.tr('-', ' ').capitalize, | |||
| provider: provider_instance.slug, | |||
| capabilities: %w[function_calling streaming], | |||
| capabilities: provider_class.capabilities.capabilities_for(model_id), | |||
There was a problem hiding this comment.
This will not work. The entire point of assume_model_exists is that the model doesn't exist. Take a look at the array of possible capabilities in models_schema.json instead.
Comment on lines
+84
to
+86
| model: 'gemini-pro', | ||
| provider: 'gemini', | ||
| assume_model_exists: true |
There was a problem hiding this comment.
I'd rather use the Ollama provider for this one and a randomized name of a model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Type of change
Scope check
Quality check
overcommit --installand all hooks passmodels.json,aliases.json)API changes
Related issues