fix: widen opentelemetry pins to ~=1.42.0#6292
Conversation
There was a problem hiding this comment.
Summary: This PR only widens OpenTelemetry dependency version constraints while retaining an upper major-version bound. No exploitable security vulnerabilities were identified in the reviewed changes.
Risk: Low risk. The change affects dependency resolution only and does not modify authentication, authorization, data handling, external request logic, or other security boundaries.
📝 WalkthroughWalkthroughIn both ChangesOpenTelemetry Dependency Version Update
Suggested Reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
greysonlalonde
left a comment
There was a problem hiding this comment.
This breaks downstream :/
There was a problem hiding this comment.
@greysonlalonde could you point at what specifically breaks? The pyproject specifiers are getting wider here (~=1.34.0 only allowed 1.34.x; >=1.34.0,<2.0.0 allows everything 1.34.x plus newer minors), so any downstream that resolved against the old pin should still resolve against the new one.
The one observable behavior change is that uv.lock now resolves the OTel stack to 1.42.1 instead of 1.34.1. Is the breakage you're seeing:
- A sibling/internal package (e.g. crewai-enterprise, crewai-tools) that pins
opentelemetry-* ~=1.34.0and now conflicts on resolution? - An actual API/runtime regression on
1.42.xthat we missed? - Something else (build/CI, transitive on
protobuf, semantic-conventions0.55b1→0.63b1, etc.)?
If you can share the failing repo + resolver/error output, we can decide between narrowing the upper bound (e.g. <1.43), pinning the lockfile back to 1.34.x while keeping the wider pyproject range, or reverting outright.
Posted on behalf of @lucasgomide
Sent by Cursor Automation: Address reviews
What exactly breaks? I will be happy to address whatever is wrong |
The previous `~=1.34.0` pin kept us on the unmaintained 1.34 line — last patched as `1.34.1` in June 2025, eight minor releases behind upstream — and caused `_create_exp_backoff_generator` `ImportError` crashes in factory deployments where the OpenTelemetry Operator's injected init container shadows `opentelemetry.exporter.otlp.proto.common._internal` with >=1.35 while our `opentelemetry-exporter-otlp-proto-grpc==1.34.1` still imports the removed private symbol. Pinning to `~=1.42.0` tracks the current upstream stable line; the resolver now lands on 1.42.1 and our public OTel trace API usage is unaffected.
911f4eb to
852fb48
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 852fb48. Configure here.



The
~=1.34.0(>=1.34.0,<1.35.0) pin kept us on the unmaintained 1.34 line — last patched as1.34.1in June 2025; the resolver now lands on 1.42.1Note
Medium Risk
Touches the telemetry export stack used by
crewai_core.telemetry, so OTLP behavior could shift across a large minor jump, but risk is limited to dependency pins and lock updates with no code changes.Overview
Bumps OpenTelemetry dependency pins from
~=1.34.0to~=1.42.0foropentelemetry-api,opentelemetry-sdk, andopentelemetry-exporter-otlp-proto-httpincrewai-coreandcrewaipyproject.tomlfiles.The lockfile is refreshed so resolved versions move from 1.34.1 to 1.42.1 (including related OTLP/proto/semantic-convention packages).
uv.lockalso sets a concreteexclude-newertimestamp instead of the prior no-op placeholder.No application or telemetry code changes—only dependency constraints and lock resolution.
Reviewed by Cursor Bugbot for commit 90e3b62. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Summary by CodeRabbit
opentelemetry-api,opentelemetry-sdk, andopentelemetry-exporter-otlp-proto-httpfrom~=1.34.0to~=1.42.0to align with newer supported versions.