Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/better conversion #8

Merged
merged 15 commits into from
Mar 8, 2023
Merged

Feat/better conversion #8

merged 15 commits into from
Mar 8, 2023

Conversation

credfeto
Copy link
Owner

@credfeto credfeto commented Mar 6, 2023

Description

Related Issue\Feature

#7

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Removed no-longer used code

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • There are no Resharper\static code analysis errors anywhere in the solution.
  • I have ONLY run a code clean-up on any files I have modified to make sure they are in the correct format and no others.
  • I have added tests to cover my changes.
  • I have run the code and quickly verified it all works to my satisfaction.
  • All new/modified code has sufficient logging to be able to diagnose what is wrong.
  • All new and existing tests passed.
  • All new/modified public interfaces/classes have are documented with xmldoc comments.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.

@credfeto credfeto self-assigned this Mar 6, 2023
@credfeto credfeto added Credfeto.Database.Source.Generation Changes in Credfeto.Database.Source.Generation project Example Changes in Credfeto.Database.Source.Generation.Example project Tests Changes in Credfeto.Database.Source.Generation.Tests project labels Mar 6, 2023
@credfeto credfeto force-pushed the feat/better-conversion branch from 3db374b to 2237212 Compare March 7, 2023 18:09
@credfeto credfeto force-pushed the feat/better-conversion branch from 2237212 to d109a17 Compare March 8, 2023 22:54
@credfeto credfeto marked this pull request as ready for review March 8, 2023 22:55
@credfeto credfeto enabled auto-merge March 8, 2023 22:56
@credfeto credfeto disabled auto-merge March 8, 2023 22:56
@credfeto credfeto merged commit 83ace7b into main Mar 8, 2023
@credfeto credfeto deleted the feat/better-conversion branch March 8, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Credfeto.Database.Source.Generation Changes in Credfeto.Database.Source.Generation project Example Changes in Credfeto.Database.Source.Generation.Example project Tests Changes in Credfeto.Database.Source.Generation.Tests project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant