Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create macadam-ready bundles #990

Open
wants to merge 5 commits into
base: release-4.17
Choose a base branch
from
Open

create macadam-ready bundles #990

wants to merge 5 commits into from

Conversation

cfergeau
Copy link
Contributor

This adds a few unit files to notify podman machine that the boot is over.
This PR purpose is to generate bundles which can be shared more easily for testing, it is not meant for merging yet.
/hold

@openshift-ci openshift-ci bot requested review from anjannath and gbraad December 13, 2024 09:14
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@praveenkumar
Copy link
Member

@cfergeau should we put wip or hold for this PR just to make sure we don't accidentally merge it until tested?

@cfergeau
Copy link
Contributor Author

@cfergeau should we put wip or hold for this PR just to make sure we don't accidentally merge it until tested?

The do-not-merge/hold label is already set, were you suggesting something more?

@praveenkumar
Copy link
Member

/test e2e-microshift

@praveenkumar
Copy link
Member

/retest

@cfergeau
Add systemd units to send 'ready' to podman machine
0edba2c 
These systemd units notify podman machine that the VM has fully finished
booting.
For hyperv, podman machine uses a dynamic port so it won't work as is.
@cfergeau
Use ${VIRT_INSTALL} instead of hardcoding virt-install
3a8243c
@cfergeau
Add display/console to make it easier to debug installations
a1bd22e
@cfergeau
Don't set MICROSHIFT_PRERELEASE
065290c 
For microshift, this will use microshift 4.17.0-rc.3 while the latest
release is currently microshift 4.17.8
@cfergeau
Don't fail to "emergency" on errors in podman ready units
8ba7944 
While this is still WIP, we need to make debugging as easy as possible.
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 14, 2025

@cfergeau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift 8ba7944 link true /test e2e-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cfergeau
Copy link
Contributor Author

One issue is that microshift bundles don't contain socat nor netcat which the systemd units require.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjannath anjannath Awaiting requested review from anjannath

@gbraad gbraad Awaiting requested review from gbraad

Assignees
No one assigned
Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfergeau @praveenkumar