[wip] add systemd services for configuration after start #980
Conversation
systemd/crc-dnsmasq.sh
Outdated
| address=/apps-crc.testing/$ip | ||
| address=/api.crc.testing/$ip | ||
| address=/api-int.crc.testing/$ip | ||
| address=/$hostName.crc.testing/$iip |
There was a problem hiding this comment.
why we need this one for node name resolve (in OCP context) Also I think ip should be node name dummy IP which is 192.168.126.11?
There was a problem hiding this comment.
yeah probably not needed now, i think this was needed before moving to SNO and in the crc code-base we still have it so added here as well
There was a problem hiding this comment.
did we test it with dummy IP 192.168.126.11 ?
There was a problem hiding this comment.
you mean using address=/$hostName.crc.testing/192.168.126.11? instead of use the result from hostname -i?
There was a problem hiding this comment.
yes right, because this is used by internal service resolution so it might work.
anjannath
force-pushed
the
issue_638
branch
4 times, most recently
from
8ccdb6e to
bd2b783
Compare
anjannath
force-pushed
the
issue_638
branch
5 times, most recently
from
525b66d to
1f5383b
Compare
systemd/ocp-cluster-status.sh
Outdated
| done | ||
|
|
||
| # need to set a marker to let `crc` know the cluster is ready | ||
| # touch /tmp/.crc-cluster-ready |
There was a problem hiding this comment.
Instead of creating a file in the guest, you can also write a 'ready' notification message to a socket. podman does something similar: cfergeau@9e80530
systemd/crc-pullsecret.sh
Outdated
| [ $retry == $max_retry ] && exit 1 | ||
| sleep 5 | ||
| ((retry++)) | ||
| done |
There was a problem hiding this comment.
I don't know if it is common/recommended to do this, but it might be possible to express "oc get secret ready" as a systemd unit
|
/test e2e-snc |
|
/retest |
anjannath
force-pushed
the
issue_638
branch
2 times, most recently
from
9fd0545 to
e6a4516
Compare
| done | ||
|
|
||
| # need to set a marker to let `crc` know the cluster is ready | ||
| # touch /tmp/.crc-cluster-ready |
There was a problem hiding this comment.
nit, Are these commented-out lines important? If not, shall we remove them?
| return 1 | ||
| } | ||
|
|
||
| # rm -rf /tmp/.crc-cluster-ready |
There was a problem hiding this comment.
anjannath
force-pushed
the
issue_638
branch
3 times, most recently
from
12df080 to
c4d5572
Compare
anjannath
force-pushed
the
issue_638
branch
4 times, most recently
from
0ed44f4 to
3881812
Compare
anjannath
force-pushed
the
issue_638
branch
5 times, most recently
from
e6d2e58 to
b2eb153
Compare
anjannath
force-pushed
the
issue_638
branch
2 times, most recently
from
394e247 to
2e2d4c4
Compare
the services does the various needed tasks to setup the ocp or microshift cluster, these systemd units runs small shell scripts which are based on: https://github.com/crc-org/crc-cloud/blob/main/pkg/bundle/setup/clustersetup.sh and does the following tasks: - creates crc specific configurations for dnsmasq - sets a new uuid as cluster id - creates the pod for routes-controller - tries to grow the disk and filesystem - checks if the cluster operators are ready - adds the pull secret to the cluster - sets kubeadmin and developer user passwords - sets a custom ca for authentication - sets custom nip.io cluster domain
|
@anjannath: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
this adds 4 small systemd services that: