Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gvforwarder as a systemd service #1003

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

gvforwarder as a systemd service #1003

wants to merge 1 commit into from

Conversation

vyasgun
Copy link

@vyasgun vyasgun commented Jan 21, 2025 •
edited
Loading

  • Create a tap device using nmcli with a hardcoded mac address
  • Start gvforwarder systemd service which will use this device

Based on the following code:
#673
cfergeau@03a4054

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vyasgun
Copy link
Author

vyasgun commented Jan 21, 2025

/test all

@cfergeau
Copy link
Contributor

I'd recommend also picking up the changes from https://github.com/cfergeau/snc/commits/gvisor_service/ which update the unit files used in the PR to use a unit file close to https://github.com/containers/gvisor-tap-vsock/tree/main/contrib/systemd

With the current code, I still have this question/concern #673 (comment)

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from fb9c40e to 6278601 Compare January 21, 2025 09:54
@vyasgun
Copy link
Author

vyasgun commented Jan 22, 2025

/retest

1 similar comment
@vyasgun
Copy link
Author

vyasgun commented Jan 23, 2025

/retest

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from 04595ac to 24924c0 Compare January 23, 2025 06:21
@vyasgun
Copy link
Author

vyasgun commented Jan 23, 2025

/retest

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from 24924c0 to 327901a Compare January 24, 2025 06:40
@vyasgun
Copy link
Author

vyasgun commented Jan 24, 2025

/retest

1 similar comment
@vyasgun
Copy link
Author

vyasgun commented Jan 24, 2025

/retest

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from 327901a to 5264a19 Compare January 27, 2025 11:23
@vyasgun
Copy link
Author

vyasgun commented Jan 27, 2025

/retest

2 similar comments
@vyasgun
Copy link
Author

vyasgun commented Jan 28, 2025

/retest

@vyasgun
Copy link
Author

vyasgun commented Feb 3, 2025

/retest

@vyasgun
Copy link
Author

vyasgun commented Feb 6, 2025

/retest

2 similar comments
@vyasgun
Copy link
Author

vyasgun commented Feb 6, 2025

/retest

@vyasgun
Copy link
Author

vyasgun commented Feb 6, 2025

/retest

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from ccc602e to 4e0a92e Compare February 7, 2025 08:47
@vyasgun
Copy link
Author

vyasgun commented Feb 7, 2025

/retest

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from 4e0a92e to a999631 Compare February 7, 2025 13:15
@vyasgun
Copy link
Author

vyasgun commented Feb 7, 2025

/retest

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from a999631 to d1501b4 Compare February 10, 2025 10:26
@vyasgun
Copy link
Author

vyasgun commented Feb 10, 2025

/retest

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch 2 times, most recently from b83b47e to 53cf03b Compare February 10, 2025 13:10
@vyasgun vyasgun changed the title [WIP] [Spike] gvforwarder as a systemd service gvforwarder as a systemd service Feb 10, 2025
@vyasgun vyasgun marked this pull request as ready for review February 10, 2025 13:17
@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from 53cf03b to 6cf746e Compare February 10, 2025 13:41
cfergeau
cfergeau reviewed Feb 10, 2025
View reviewed changes
createdisk.sh Outdated Show resolved Hide resolved
cfergeau
cfergeau reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot for putting this into shape/testing it.

[email protected] Outdated Show resolved Hide resolved
@vyasgun
Copy link
Author

vyasgun commented Feb 11, 2025

/test e2e-snc

@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from 6cf746e to abece15 Compare February 11, 2025 03:37
@vyasgun
gvforwarder as a systemd service
cf5affc 
- Create a tap device using nmcli with a hardcoded mac address
- Start gvforwarder systemd service which will use this device

Signed-off-by: vyasgun <[email protected]>
@vyasgun vyasgun force-pushed the spike/gvforwarder-service branch from abece15 to cf5affc Compare February 11, 2025 03:38
cfergeau
cfergeau reviewed Feb 11, 2025
View reviewed changes
createdisk.sh
# when tap device is in use.
${SSH} core@${VM_IP} 'sudo bash -x -s' <<EOF
nmcli connection add type tun ifname tap0 con-name tap0 mode tap autoconnect yes 802-3-ethernet.cloned-mac-address 5A:94:EF:E4:0C:EE
EOF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this equivalent to ${SSH} core@${VM_IP} 'sudo nmcli connection add type tun ifname tap0 con-name tap0 mode tap autoconnect yes 802-3-ethernet.cloned-mac-address 5A:94:EF:E4:0C:EE'?

@cfergeau
Copy link
Contributor

@praveenkumar can you take a look at this PR? you also looked into this in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfergeau cfergeau cfergeau left review comments

@gbraad gbraad Awaiting requested review from gbraad

@praveenkumar praveenkumar Awaiting requested review from praveenkumar

Assignees

@vyasgun vyasgun

Labels
None yet
Projects
Project planning: crc
Status: Work In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasgun @cfergeau