Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.21 #118

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

praveenkumar
Copy link
Member

@praveenkumar praveenkumar commented May 27, 2024

Since 1.18 is already EOL and all our tooling migrated to go-1.21

Copy link

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@praveenkumar
Copy link
Member Author

Why?

@cfergeau added in the commit logs

Since 1.18 is already EOL and all our tooling migrated to go-1.21

- https://endoflife.date/go
Copy link

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not 100% sure from the commit log if this is a change which is required, or if it's something we do for consistency with the rest of our stack.
The fact that go.mod says 1.19 does not prevent us from using 1.21 or 1.22 for building.

@praveenkumar
Copy link
Member Author

I'm still not 100% sure from the commit log if this is a change which is required, or if it's something we do for consistency with the rest of our stack.

The fact that go.mod says 1.19 does not prevent us from using 1.21 or 1.22 for building.

it doesn't prevent us to use latest version of golang but it also doesn't prevent some to build it on older version since it is already EOL so I am not sure what else would be best reason to have it in.

@cfergeau
Copy link

I'm still not 100% sure from the commit log if this is a change which is required, or if it's something we do for consistency with the rest of our stack.

I still have no idea about this. I think you are saying this is not a required change (required because something is broken if we try to build with go 1.19 or 1.20), but that it's better to have this for consistency/because go older than 1.21 is not supported/..., which is fine with me.

@praveenkumar
Copy link
Member Author

I'm still not 100% sure from the commit log if this is a change which is required, or if it's something we do for consistency with the rest of our stack.

I still have no idea about this. I think you are saying this is not a required change (required because something is broken if we try to build with go 1.19 or 1.20), but that it's better to have this for consistency/because go older than 1.21 is not supported/..., which is fine with me.

That's what I put in the commit log, since 1.18 is outdated and our tooling already moved to 1.21

@praveenkumar praveenkumar merged commit 894e1d0 into crc-org:master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants