-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version to 1.21 #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
22677c6
to
b917bc0
Compare
@cfergeau added in the commit logs |
Since 1.18 is already EOL and all our tooling migrated to go-1.21 - https://endoflife.date/go
b917bc0
to
f1f5cb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not 100% sure from the commit log if this is a change which is required, or if it's something we do for consistency with the rest of our stack.
The fact that go.mod says 1.19
does not prevent us from using 1.21 or 1.22 for building.
it doesn't prevent us to use latest version of golang but it also doesn't prevent some to build it on older version since it is already EOL so I am not sure what else would be best reason to have it in. |
I still have no idea about this. I think you are saying this is not a required change (required because something is broken if we try to build with go 1.19 or 1.20), but that it's better to have this for consistency/because go older than 1.21 is not supported/..., which is fine with me. |
That's what I put in the commit log, since 1.18 is outdated and our tooling already moved to 1.21 |
Since 1.18 is already EOL and all our tooling migrated to go-1.21