Skip to content

Commit

Permalink
Use same hyperkit qcow2 parameters as before
Browse files Browse the repository at this point in the history
With the update of the hyperkit go module, the hyperkit commandline
for qcow2 disks changed and became more complicated:
-s 2:0,virtio-blk,file:///Users/crcqe/.crc/machines/crc/crc.qcow2?sync=&buffered=1,format=qcow,qcow-config=discard=true;compact_after_unmaps=0;keep_erased=0;runtime_asserts=false

Before it was simpler:
-s 2:0,virtio-blk,file:///Users/teuf/.crc/machines/crc/crc.qcow2,format=qcow

We've been hitting disk related failures during our testing of the
machine driver, so let's switch back to the same qcow2 options as before
this go module update. Hopefully this will help.
  • Loading branch information
cfergeau authored and guillaumerose committed Mar 22, 2021
1 parent 4434d68 commit f57ae1c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/hyperkit/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ func (qcow *QcowDisk) Ensure() error {
return nil
}

func (qcow *QcowDisk) AsArgument() string {
return fmt.Sprintf("virtio-blk,file://%s,format=qcow", qcow.Path)
}

// NewDriver creates a new driver for a host
func NewDriver() *Driver {
return &Driver{
Expand Down

0 comments on commit f57ae1c

Please sign in to comment.