Skip to content

Integrate: Add dedicated page about DataGrip #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Integrate: Add dedicated page about DataGrip #155

merged 3 commits into from
Dec 5, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Dec 5, 2024

For connecting to CrateDB, the [CrateDB JDBC Driver] will be used.
:::
:::{grid-item}
![Image](https://github.com/user-attachments/assets/ebd11a53-4d4a-4a9b-bed2-25909e618929){w=480px}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be up-to-date, there are 2 options legacy and non-legacy
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will probably need to ramp up a DBeaver myself, in order to capture the current state of affairs better. Within this iteration, I just reused existing resources for DBeaver. Maybe I will split the PR into two halves.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've diverted concerns about DBeaver to GH-157.

```
:::
:::{grid-item}
![Image](https://github.com/user-attachments/assets/3288ab3f-a70a-42db-8b99-051ea3051c84){w=480px}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks fairly different now, with a radio box switching between connect by host or URL:

Screenshot 2024-12-05 at 11 26 09

Copy link
Member Author

@amotl amotl Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As mentioned above in the reply to @hlcianfagna, I figure the rework of the page about DBeaver needs more love, so I may break relevant changes out of this PR into a separate one.

Let me still ask one question: I figured the right way to use DBeaver would also be to use the CrateDB JDBC Driver instead of the vanilla pgJDBC driver, as it seems to be the right choice also for DataGrip, Apache Flink, and other integrations. Now that you are showing a settings dialogue that uses jdbc:postgresql://, do you think I should adjust my assumption?

NB: The tutorial Blog: Use CrateDB With DBeaver also indicates that the CrateDB JDBC Driver should be used, including its specific protocol identifier jdbc:crate://.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've diverted concerns about DBeaver to GH-157.

@amotl amotl force-pushed the refactor-ide branch 2 times, most recently from be8f07e to 5fee715 Compare December 5, 2024 14:39
@amotl amotl changed the title Integrate: Add dedicated pages about DataGrip and DBeaver Integrate: Add dedicated pages about DataGrip Dec 5, 2024
@amotl amotl changed the title Integrate: Add dedicated pages about DataGrip Integrate: Add dedicated page about DataGrip Dec 5, 2024
@amotl amotl merged commit ed46829 into main Dec 5, 2024
3 checks passed
@amotl amotl deleted the refactor-ide branch December 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants