Make datetime.time json serializable, to string ISO format.#701
Open
Make datetime.time json serializable, to string ISO format.#701
Conversation
surister
force-pushed
the
fix/datetime-time-serializable
branch
from
c77c110 to
a4fbe65
Compare
surister
force-pushed
the
fix/datetime-time-serializable
branch
from
a4fbe65 to
3b00367
Compare
Member
Author
|
Docs failing with |
seut
reviewed
Feb 25, 2025
| request.return_value = fake_response(200) | ||
|
|
||
| obj = dt.datetime.now().time() | ||
| client.sql("insert into my_table (str_col) values (?)", (obj,)) |
Member
There was a problem hiding this comment.
This is not really testing that the time format is correct and understood by CrateDB as it will just take the given string and stores it.
Suggested change
| client.sql("insert into my_table (str_col) values (?)", (obj,)) | |
| client.sql("SELECT ?::TIMETZ AS t_tz", (obj,)) |
Additionally, this would test the decoding of a TIMETZ type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Fixes #696
Checklist