Skip to content

Conversation

@daminichopra
Copy link

@daminichopra daminichopra commented Feb 4, 2020

Summary of the changes / Why this is an improvement

Updated code in http.py and introduced backoff_factor=0.0 as this parameter can do retry interval between consecutive retries. So, that when user want to change value of backoff_factor=0.0 to 0.0,0.1,0.2 ... for retry interval they can edit value of backoff_factor as per requirement.

Checklist

  • [ OK ] CLA is signed

@daminichopra daminichopra changed the title Update http.py Update code for retry interval between retries Feb 4, 2020
@autophagy autophagy self-requested a review February 4, 2020 08:14
@autophagy
Copy link
Contributor

@daminichopra Hi Damini, thank you for submitting a pull request. 🙂

If I'm correct, this PR is related to #339, which was about the lack of a time backoff when retrying an unavailable CrateDB server? According to the documentation for urllib3, "by default, backoff is disabled (set to 0)." https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#module-urllib3.util.retry

Since this is already 0 by default, I'm not sure setting it as 0 would have the desired effect. What is the effect you wanted this change to have? Would you be able to explain the intention behind this change more in the commit message? Thank you!

@daminichopra
Copy link
Author

daminichopra commented Feb 4, 2020

Hi @autophagy , yes it is related to #339. Also, I have updated the summary for the PR. Please confirm. Thank you :)

@daminichopra Hi Damini, thank you for submitting a pull request.

If I'm correct, this PR is related to #339, which was about the lack of a time backoff when retrying an unavailable CrateDB server? According to the documentation for urllib3, "by default, backoff is disabled (set to 0)." https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#module-urllib3.util.retry

Since this is already 0 by default, I'm not sure setting it as 0 would have the desired effect. What is the effect you wanted this change to have? Would you be able to explain the intention behind this change more in the commit message? Thank you!

@autophagy
Copy link
Contributor

@daminichopra Thank you for the response. I'm still a little confused 😅 how would another user go about changing this value? Directly in the code?

@daminichopra
Copy link
Author

Hi @autophagy , yes you are right. To change value of "backoff_factor", i think we need to make it configurable in crateDb code by initializing new parameter "backoff_factor" . If you have any other opinion then Please suggest. Thank you :)

@daminichopra
Copy link
Author

In refrence to PR#342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants