fix: autocomplete script comparison in interactie shell #493
+900
−853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki725
force-pushed
the
autocomplete
branch
from
61f72ff to
b629923
Compare
4 tasks
instead of hardcoding autocomplete version in chalk codebase, use chalk version itself
miki725
force-pushed
the
autocomplete
branch
2 times, most recently
from
d005f1f to
ef52e10
Compare
autocomplete now fully uses that codec to update the autocomplete shell script on system when using TTY session
instead of 2 versions of autocomplete, make the default one more generic with if statements so its more reliable
miki725
force-pushed
the
autocomplete
branch
from
fb7a45a to
3826f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif necessaryIssue
fixes #251
Description
The autocomplete script is now chalked on-disk during installation from chalk metadata vs embedding that metadata to script which is embedded in the repo. This required some rework of the source scripts plugin along with some collection logic such as to ignore all irrelevant plugins when copying metadata from one chalk object to another.
Testing
./chalk versionrm -rf ~/.local/share/bash_completion/completions/chalk.bash; ./chalk versioncheck that its only updated when necessary