feat: adding EXTERNAL_TOOL_DURATION key

[miki725]

• Followed the steps in the contributor's guide: https://crashoverride.com/docs/other/contributing#filing-the-pull-request
• PR title uses semantic commit messages
• Filled out the template to a useful degree
• Updated CHANGELOG.md if necessary

Description

To help analyze whats the overhead of the tool, report its duration as a separate key

Testing

➜ maketest test_plugins.py::test_semgrep --pdb

[miki725]

https://app.shortcut.com/crashoverride-1/story/4516/chalk-report-external-tool-duration

[mbaltrusitis]

What do you think of adding a TOTAL_EXTERNAL_TOOL_DURATION key that performs the aggregate?

[mbaltrusitis]

LGTM. see comment.

[miki725]

adding more aggregate for aggregate tool collection sounds like a good idea but we can probably do that in a separate PR. Ill probably merge this for now and we can add additional keys separately.

[mbaltrusitis]

adding more aggregate for aggregate tool collection sounds like a good idea but we can probably do that in a separate PR. Ill probably merge this for now and we can add additional keys separately.

completely agree