Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heartbeats timestamp #487

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix: heartbeats timestamp #487

merged 1 commit into from
Feb 12, 2025

Conversation

miki725
Copy link
Collaborator

@miki725 miki725 commented Feb 11, 2025

Issue

heartbeats have incorrect timestamp

Description

Heartbeat reports had older timestamps. Reporting state was cleared before sleeping for the heartbeat which meant that timestamp was always off by the heartbeats interval - default 10 minutes.

Testing

Run

./chalk exec -- sleep 300

and observe reported timestamp locally.

@miki725 miki725 requested a review from louisja February 11, 2025 20:12
Base automatically changed from frontend to main February 11, 2025 21:24
Heartbeat reports had older timestamps. Reporting state was cleared
before sleeping for the heartbeat which meant that timestamp was
always off by the heartbeats interval - default 10 minutes.
@miki725 miki725 marked this pull request as ready for review February 11, 2025 21:25
@miki725 miki725 requested a review from viega as a code owner February 11, 2025 21:25
@miki725 miki725 merged commit 7251932 into main Feb 12, 2025
4 checks passed
@miki725 miki725 deleted the heartbeats branch February 12, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants