fix: check buildkit frontend version to determine context arg compatibility #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility Not all older frontends support `--build-arg` and sometimes they do no specify the version as part of the syntax directive. For example: ``` syntax: docker/dockerfile:experimental ``` Chalk cannot infer anything about the meaning of `experimental` as its not pinned to any version. Therefore we call the dockerfile frontend container and check its actual version. This is possibly not as efficient even if the version is specified however that would also require some heuristics. For example: ``` syntax: docker/dockerfile:1 ``` As `1` can change over time it might not be clear which syntax should actually be honored. Therefore it is probably a lot simpler to simply ask it what version it is instead of possibly error-prone version detection heuristics.
mbaltrusitis
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif necessaryIssue
Builds which specify frontend can sometimes fallback due to incompatible
--build-argDescription
Not all older frontends support
--build-argand sometimes they do no specify the version as part of the syntax directive. For example:Chalk cannot infer anything about the meaning of
experimentalas its not pinned to any version. Therefore we call the dockerfile frontend container and check its actual version.This is possibly not as efficient even if the version is specified however that would also require some heuristics. For example:
As
1can change over time it might not be clear which syntax should actually be honored. Therefore it is probably a lot simpler to simply ask it what version it is instead of possibly error-prone version detection heuristics.Testing