Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run external tools on git repo folder #485

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix: run external tools on git repo folder #485

merged 2 commits into from
Feb 10, 2025

Conversation

miki725
Copy link
Collaborator

@miki725 miki725 commented Feb 6, 2025

Issue

External tools would run against specific file being chalked.

Description

When running external tool for chalk insert it should run on a git repo, not on the path of the chalked artifact. For example:

chalk insert hello.py

Should run semgrep on the git repo, not hello.py.

Testing

➜ maketest test_plugins.py::test_semgrep[sample_1-True] --logs --pdb

@miki725 miki725 requested a review from viega as a code owner February 6, 2025 17:57
@miki725 miki725 force-pushed the semgrep branch 2 times, most recently from 5cd00bb to 245d85a Compare February 10, 2025 13:31
When running external tool for `chalk insert` it should run on a git
repo, not on the path of the chalked artifact. For example:

```
chalk insert hello.py
```

Should run `semgrep` on the git repo, not `hello.py`.
@miki725 miki725 merged commit 511476d into main Feb 10, 2025
2 checks passed
@miki725 miki725 deleted the semgrep branch February 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants