-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(attestation/api): Changes to signing key backup service + chalk client side bindings #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of chalk data api key to be a config
…backup service...' vars
… test was failing
miki725
reviewed
Jan 11, 2024
Comment on lines
+147
to
+148
retries = 2, | ||
firstRetryDelayMs = 100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet I see you are already using retries 🎉
viega
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
No public issues associated with this PR
Description
This PR covers a number of changes related to the refactor of the signing key backup service (the artist formerly known, confusingly, as 'secrets manager'). Notably:
api.nim
is no longer needed and was removedlogin
andlogout
have been removedsecret manager
related names tosigning key backup service
related names, this should hopefully provide better clarity of code and reduce overuse of 'secret managers' everywhere.Chalk API
is now refered to as theChalk Data API
to better distinguish it from other APIsCHALK_API_KEY
->CHALK_DATA_API_KEY
use_secret_manager
->use_signing_key_backup_service
secret_manager_url
->signing_key_backup_service_url
secret_manager_timeout
->signing_key_backup_service_timeout
/secrets-manager
to/signing-key-backup
nosecretmanager.c4m
tonosigningkeybackup.c4m
Testing
rm chalk{.key,.pub}
# ensure nochalk.key
orchalk.pub
files are already presentchalk load config_file_with_jwt.c4m
# load chalk data api token via config & new auth stanzachalk --trace setup
# gens keys locally, encrypts, & saves them to servicechalk --trace setup
# retrieves saved keys from service, decrypts