Repository navigation
[6.x] Treat table column widths without a unit as pixels - #20808
Open
brandonkelly wants to merge 1 commit into
Open
brandonkelly wants to merge 1 commit into
brandonkelly wants to merge 1 commit into
Conversation
Craft 5 treated a unitless editable table column width as pixels. The Vue table control passed numeric strings through as invalid CSS, so the browser dropped them, and turned numbers into percentages. Both are now pixels, and the Matrix and section site settings tables, which relied on numbers being percentages, say 50% explicitly. Fixes #20781 Amp-Thread-ID: https://ampcode.com/threads/T-1a8914a2-23e7-4987-9f39-2961bca2b65a Co-authored-by: Amp <amp@ampcode.com>
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook Changed components: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Editable table column widths without a unit are pixels again, as in Craft 5.
The Matrix and section site settings tables relied on bare numbers meaning percent, so they now say
'50%'.Evidence
Table field with widths
400and100, measuredthead thwidths:style.widthempty; Item 192px, Quantity 309px (sized by content)400px/100px; Item 400px, Quantity 100pxSection edit's URI Format and Route To columns still split evenly at
50%.Related issues