Repository navigation
Conversation
Plugins load once per request, so a plugin enabled or installed since then isn't in getPlugin(). That broke two things that worked in Craft 5: - Disabling or uninstalling a plugin enabled earlier in the same request threw InvalidPluginException. Both now create the plugin's instance when it's enabled but wasn't loaded. A forced uninstall of a disabled plugin still gets no instance, as before. - installPlugin() stored only the plugin's ID and enabled flag, so isPluginUpdatePending() hit an undefined schemaVersion key. Installing now builds the stored info the same way loadPlugins() does. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a1e8d1-9981-7090-9108-69125aec9ad4
getPluginInfo()['isEnabled'] checked whether the plugin was loaded at boot, while isPluginEnabled() and the MCP capability read the stored enabled flag. It now uses isPluginEnabled(), so the plugin commands and the control panel see the same answer, and its editions and settings flags come from the plugin even when it was enabled after plugins loaded. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a1e8d1-9981-7090-9108-69125aec9ad4
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Plugin state lives in the
pluginstable, project config and memory. Changing it more than once in a request left them out of step.Evidence
isPluginUpdatePending()hit a missingschemaVersionkey after an install.After:
PluginLifecycleTestcovers each case, and the tests fail on the old code.