Repository navigation
[5.x] Fix storeLocalSource() default destination - #20775
Merged
Merged
Conversation
Calling storeLocalSource() without a destination now resizes the source in place, instead of overwriting the source path with the empty destination and doing nothing. Amp-Thread-ID: https://ampcode.com/threads/T-20f1a16b-046e-45e5-8264-23d3d87506c4 Co-authored-by: Amp <amp@ampcode.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the fix restoring in-place image resizing when no destination is supplied.
No open issues 🎉
What changed in this PR
Fixes ImageTransforms::storeLocalSource() so callers that omit a destination resize the source file in place. Core callers already pass a destination and are unaffected.
Changes:
- Corrects the default assignment to preserve the source path and use it as the destination.
- Adds a changelog entry describing the fix.
| File | Description |
|---|---|
src/helpers/ImageTransforms.php |
Defaults the destination to the source path. |
CHANGELOG.md |
Documents the corrected in-place resizing behavior. |
Review effort: Balanced
Amp-Thread-ID: https://ampcode.com/threads/T-fd8229b7-a0fa-4479-ab37-a4da54e2100a Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
craft\helpers\ImageTransforms::storeLocalSource()is meant to resize the source file in place when no destination is passed. The default was assigned backwards, so the source path got blanked out and the call did nothing:if (!$destination) { - $source = $destination; + $destination = $source; }Core always passes a destination, so this only affects plugins and other code that leave it out.
When this merges into 6.x,
src/helpers/ImageTransforms.phpwill conflict because the method moved tosrc/Image/ImageTransformHelper.php(ImageTransformHelper::storeLocalSource()). The same one-line fix needs to go there.