Skip to content

Port to Tauri 2.x #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 27, 2024
Merged

Port to Tauri 2.x #49

merged 11 commits into from
May 27, 2024

Conversation

vdang-crabnebula
Copy link
Contributor

Fix SEC-237

Copy link

linear bot commented May 21, 2024

@vdang-crabnebula
Copy link
Contributor Author

This does not pass the windows test but I will tackle this in another PR.
I'd like to merge this one

@tillmann-crabnebula
Copy link
Contributor

There is a breaking change in the InvokeRequest in the newest beta release due to GHSA-57fm-592m-34r7 and we need to add the invoke key to the requests afaik.

@vdang-crabnebula
Copy link
Contributor Author

There is a breaking change in the InvokeRequest in the newest beta release due to GHSA-57fm-592m-34r7 and we need to add the invoke key to the requests afaik.

The timing is perfect I don't need to do another PR. (tragic in my mind, I thought I was done with it )

@vdang-crabnebula
Copy link
Contributor Author

This is ready for merge!

@tillmann-crabnebula
Copy link
Contributor

LGTM.

Only nitpick would be that we don't need to check in the gen/ folder of the tauri apps, as they will be auto-generated by the build system. Our custom capabilities should land in the capabilities folder or if we don't modify then auto generate for each build.

@vdang-crabnebula
Copy link
Contributor Author

vdang-crabnebula commented May 27, 2024

LGTM.

Only nitpick would be that we don't need to check in the gen/ folder of the tauri apps, as they will be auto-generated by the build system. Our custom capabilities should land in the capabilities folder or if we don't modify then auto generate for each build.

Alright. I will remove them from the repo and add it to .gitignore in this PR (which is ahead) to avoid dealing with conflict history.

@vdang-crabnebula vdang-crabnebula merged commit 773b457 into main May 27, 2024
6 checks passed
@vdang-crabnebula vdang-crabnebula deleted the tauri-2.x branch May 27, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants