Update README.md #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct a typo.
|
Thank you for the library, but I think you made a small typo when describing it. |
I had some issues with the library, which these unittests helped me to understand. The answers appear to be approximate to within +/- about a minute. This is fine if it's known, but very confusing otherwise.
|
I had some confusing issues using this library, because the calculated sunrise/sunset can vary depending on what time of day is used in the call to calculate them. This can even lead to timers based on NextSunrise/NextSunset firing multiple times in the same day. These unittests helped me to understand the problem, and the workaround (use approximate time comparisons). I left one failure in place just to demonstrate. I just wanted to show it to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct a typo.