[Nussu06]

polyspace::Parser::parseRange reads the +N range of a Polyspace comment with std::stoi and only catches std::invalid_argument, so a source file containing /* polyspace +99999999999 MISRA2012:8.4 */ throws std::out_of_range past CppCheck::checkFile and aborts cppcheck when it runs with --inline-suppr and the misra addon or a premium MISRA/CERT option. A range that does fit, such as +2147483647 on line 2, instead overflows line + rangeValue in Parser::parse (UBSan: signed integer overflow) and leaves a negative lineEnd. An out-of-range number is now treated like any other invalid range, and lineEnd is clamped to INT_MAX instead of wrapping, so valid ranges are unchanged. The new asserts in polyspaceParseRange and polyspaceRange fail on main, and the full testrunner passes in an ASan/UBSan build. There is no Trac ticket for this yet; I can update the title once one exists.

[dmcppcheck]

There should probably be a trac ticket for this PR. Please create it, or ask us to create it. Then the PR title should be updated.

[Nussu06]

I don't have Trac access, so could you create the ticket for this one? Once there's a number I'll update the title to "Fix #NNNN (...)" like the others.

For the ticket: with --inline-suppr and the misra addon (or a premium MISRA/CERT/AUTOSAR option), a Polyspace annotation whose +N range doesn't fit in an int crashes cppcheck, because polyspace::Parser::parseRange only catches std::invalid_argument from std::stoi:

printf 'int x;\n/* polyspace +99999999999 MISRA2012:8.4 */\nint y;\n' > b.c
cppcheck --inline-suppr --addon=misra -q b.c
# terminating due to uncaught exception of type std::out_of_range: stoi: out of range

A range that does fit, e.g. +2147483647 on line 2, overflows line + rangeValue in Parser::parse instead (UBSan: signed integer overflow) and gives a negative lineEnd.

[danmar]

I have created https://trac.cppcheck.net/ticket/15181