-
Notifications
You must be signed in to change notification settings - Fork 0
feat: update README.md to add clang-tools-wheel #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the README to include the new clang-tools-wheel repository alongside existing clang-tools distribution methods. The update expands the available options for using clang tools by adding Python wheel distribution as an alternative to static binaries and Docker images.
- Added reference to clang-tools-wheel repository in the documentation
- Updated descriptive text to include "Python wheels" as a distribution method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I had a look at those packages. The CI uses qemu to properly cross-compile the binaries for distribution on PyPI 👍🏼 Indeed, this would be a good replacement for our faulty static binaries. One thing I'd like to point out is that the history does not go back to clang v10. I think those |
|
@shenxianpeng I think ssciwr/clang-tidy-wheel#100 can now be closed since the request release has been deployed. |
I’ve redistributed the clang-tools Python wheels to GitHub releases without making any changes upstream. The goal is to have the wheels readily available when needed, without having to wait for an upstream request—similar to what was done in ssciwr/clang-tidy-wheel#100 and ssciwr/clang-tidy-wheel#96
And maybe it can replace https://github.com/cpp-linter/clang-tools-static-binaries via clang-tools CLI in the future..
Summary by CodeRabbit