Working on comments #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rinzii
added
documentation
karnkaul
force-pushed
the
commenting-cleanup
branch
2 times, most recently
from
2349551 to
4383814
Compare
karnkaul
force-pushed
the
commenting-cleanup
branch
from
4383814 to
f3e1b00
Compare
Also rename `RingBuffer` to `Rotator`.
- Remove rect.hpp (unused). - `Transform` was initially more complex: contained child transforms too. Since it is now a pure data component agnostic to the scene, it has been moved to util.
|
@Rinzii It would be prudent to merge this in and continue the remaining work in another PR. |
|
Force merging due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently working on the commenting across the entire project. Gonna take a bit so I'm gonna keep this as an ongoing PR. @karnkaul if you see comments that are incorrect or if you have suggestions to make them better as I continue to work on the PR lmk. ^^