Skip to content

[input.output] Fix missing is \keyword{true} or is \keyword{false} #6534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Eisenwave
Copy link
Contributor

Similar fixes to #6526

I've realized halfway through just how much work there is to do, and so I'd like some feedback on how to proceed first.

My plan is to cherry-pick the commits and put each into a separate PR so that they can be examined and discussed separately. After all, there are some wording changes, it's not just changing formatting for some words.

@Eisenwave Eisenwave changed the title [input.outpu] Fix missing is \keyword{true} or is \keyword{false} [input.output] Fix missing is \keyword{true} or is \keyword{false} Aug 30, 2023
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 17, 2024
@Eisenwave Eisenwave marked this pull request as ready for review March 30, 2025 08:10
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody likes the requirement to say "is true" in places like this, so it would be better to use wording like "a equals b" instead of the clunky "a == b is true"

\tcode{pl += o} &
\tcode{P\&} &
\tcode{+=} offset &
\remarks With \tcode{ql = pl;} before the \tcode{+=}, then:
\tcode{pl - o == ql} \\ \rowsep
\tcode{pl - o == ql} is \keyword{true} \\ \rowsep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\tcode{pl - o == ql} is \keyword{true} \\ \rowsep
\tcode{pl - o} equals \tcode{ql} \\ \rowsep

And similarly below

@@ -2034,7 +2036,7 @@
\tcode{ios_base::imbue(loc)}\iref{ios.base.locales}
and
if
\tcode{rdbuf() != 0}
\tcode{rdbuf() != 0} is \keyword{true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rbduf() is null, or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants