[input.output] Fix missing is \keyword{true} or is \keyword{false}#6534
Closed
eisenwave wants to merge 20 commits into
Closed
[input.output] Fix missing is \keyword{true} or is \keyword{false}#6534eisenwave wants to merge 20 commits into
is \keyword{true} or is \keyword{false}#6534eisenwave wants to merge 20 commits into
Conversation
eisenwave
changed the title
is \keyword{true} or is \keyword{false}is \keyword{true} or is \keyword{false}
wg21bot
added
the
needs rebase
jwakely
reviewed
Mar 30, 2025
jwakely
left a comment
jwakely
left a comment
Member
There was a problem hiding this comment.
Nobody likes the requirement to say "is true" in places like this, so it would be better to use wording like "a equals b" instead of the clunky "a == b is true"
| \tcode{+=} offset & | ||
| \remarks With \tcode{ql = pl;} before the \tcode{+=}, then: | ||
| \tcode{pl - o == ql} \\ \rowsep | ||
| \tcode{pl - o == ql} is \keyword{true} \\ \rowsep |
Member
There was a problem hiding this comment.
Suggested change
| \tcode{pl - o == ql} is \keyword{true} \\ \rowsep | |
| \tcode{pl - o} equals \tcode{ql} \\ \rowsep |
And similarly below
| and | ||
| if | ||
| \tcode{rdbuf() != 0} | ||
| \tcode{rdbuf() != 0} is \keyword{true} |
Member
There was a problem hiding this comment.
rbduf() is null, or something like that
Member
Author
|
Too big of a change for one PR, and subject to regression. Maybe if we have checks in the future that can be toggled within certain regions of the markup, we could do some automatic detection, but for now we probably have more important things to focus on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar fixes to #6526
I've realized halfway through just how much work there is to do, and so I'd like some feedback on how to proceed first.
My plan is to cherry-pick the commits and put each into a separate PR so that they can be examined and discussed separately. After all, there are some wording changes, it's not just changing formatting for some words.