[Backport release-1.2] fix(mariadb): remove duplicate template key in backup CronJob

[kvaps]

Summary

Minimal backport from #2279 to release-1.2 — only the duplicate-template: key removal in packages/apps/mariadb/templates/backup-cronjob.yaml, without the breaking service-naming / forced-replication changes from #2279 (those are not appropriate for a patch release).

Fixes the yaml: unmarshal errors: line 17: mapping key "template" already defined at line 14 error when deploying MariaDB with backup.enabled: true on v1.2.x.

Related: #2293

Test plan

• helm template of the mariadb chart with backup.enabled: true renders without YAML duplicate-key errors
• CronJob deploys successfully on a v1.2.x cluster

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d540151-d9c3-4b18-a70c-3c2de107106c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/mariadb-backup-duplicate-key-release-1.2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a deployment issue in the MariaDB chart for the release-1.2 branch. By eliminating a redundant key in the CronJob template, the configuration now adheres to valid YAML syntax, ensuring that deployments with backups enabled can proceed without encountering unmarshal errors.

Highlights

• YAML Syntax Correction: Removed a duplicate 'template' key in the MariaDB backup CronJob definition to resolve unmarshal errors during deployment.
• Backport Implementation: Successfully backported the fix from PR [mariadb] fix: always enable replication for consistent service naming #2279 to the release-1.2 branch without including unrelated breaking changes.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request cleans up the MariaDB backup CronJob template by removing a redundant template specification block. The review feedback indicates that the pull request body is missing the mandatory release-note block required by the project's style guide.

[gemini-code-assist]

The pull request body is missing the required release-note block. According to the repository style guide, every PR must include a release note block in the following format:

```release-note
type(scope): human-readable changelog entry

<details>
<summary>References</summary>

1. PR body must contain a release note block. Flag any PR whose body has no release-note block. <sup>([link](https://github.com/cozystack/cozystack/blob/main/.gemini/styleguide.md))</sup>
</details>