fix(ci): ensure correct latest release after backport publishing #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace unreliable getLatestRelease() API with semver-based max version detection. After publishing a backport release, explicitly restore the latest flag on the highest semver release to handle cases where GitHub API ignores make_latest: 'false'. Also remove dead code (unused steps) from tags.yaml workflow. Co-Authored-By: Claude <[email protected]> Signed-off-by: Andrei Kvapil <[email protected]>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request refactors release workflow logic by moving semver comparison and latest-release determination from external API calls into the workflows themselves. The tags workflow is simplified by removing semver comparison, while the pull-requests-release workflow adds internal semver parsing and conditional release adjustment logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kvaps
added
backport
dosubot
bot
added
the
size:L
|
Git push to origin failed for release-0.39 with exitcode 1 |
|
Git push to origin failed for release-0.38 with exitcode 1 |
kvaps
added a commit
that referenced
this pull request
Jan 8, 2026
## What this PR does Fixes an issue where backport releases incorrectly became marked as "Latest" despite passing `make_latest: 'false'` to the GitHub API. **Root cause:** The `getLatestRelease()` API returns the release with the "Latest" flag, not the highest semver version. Combined with race conditions during parallel release publishing and GitHub API potentially ignoring `make_latest: 'false'`, backport releases were incorrectly marked as latest. **Solution:** - Replace `getLatestRelease()` with semver-based max version detection across all published releases - After publishing a backport release, explicitly restore the latest flag on the highest semver release - Remove unused dead code from `tags.yaml` workflow ### Release note ```release-note [ci] Fix latest release detection to use semver comparison instead of GitHub's "Latest" flag ```
kvaps
added a commit
that referenced
this pull request
Jan 8, 2026
## What this PR does Fixes an issue where backport releases incorrectly became marked as "Latest" despite passing `make_latest: 'false'` to the GitHub API. **Root cause:** The `getLatestRelease()` API returns the release with the "Latest" flag, not the highest semver version. Combined with race conditions during parallel release publishing and GitHub API potentially ignoring `make_latest: 'false'`, backport releases were incorrectly marked as latest. **Solution:** - Replace `getLatestRelease()` with semver-based max version detection across all published releases - After publishing a backport release, explicitly restore the latest flag on the highest semver release - Remove unused dead code from `tags.yaml` workflow ### Release note ```release-note [ci] Fix latest release detection to use semver comparison instead of GitHub's "Latest" flag ```
kvaps
added a commit
that referenced
this pull request
Jan 9, 2026
## What this PR does Fixes an issue where backport releases incorrectly became marked as "Latest" despite passing `make_latest: 'false'` to the GitHub API. **Root cause:** The `getLatestRelease()` API returns the release with the "Latest" flag, not the highest semver version. Combined with race conditions during parallel release publishing and GitHub API potentially ignoring `make_latest: 'false'`, backport releases were incorrectly marked as latest. **Solution:** - Replace `getLatestRelease()` with semver-based max version detection across all published releases - After publishing a backport release, explicitly restore the latest flag on the highest semver release - Remove unused dead code from `tags.yaml` workflow ### Release note ```release-note [ci] Fix latest release detection to use semver comparison instead of GitHub's "Latest" flag ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes an issue where backport releases incorrectly became marked as "Latest" despite passing
make_latest: 'false'to the GitHub API.Root cause: The
getLatestRelease()API returns the release with the "Latest" flag, not the highest semver version. Combined with race conditions during parallel release publishing and GitHub API potentially ignoringmake_latest: 'false', backport releases were incorrectly marked as latest.Solution:
getLatestRelease()with semver-based max version detection across all published releasestags.yamlworkflowRelease note
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.