Merge pull request #293 from clochix/master

Fix error with 2FA recovery code, refs #292
cozy · Jul 11, 2016 · 2eba08d · 2eba08d
2 parents d44b4b0 + 5390d84
commit 2eba08d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/middlewares/authentication.coffee b/server/middlewares/authentication.coffee
@@ -43,12 +43,12 @@ disableRecoveryCode = (user, codes, index, callback) ->
 
 attemptRecoveryCodes = (user, req, res, next) ->
     User.first (err, user) ->
-        codes = JSON.parse(user.encryptedRecoveryCodes)
         if err
             next makeError 401, 'no user found', err
         else if not user.encryptedRecoveryCodes?
             next makeError 401, 'error otp invalid code'
         else
+            codes = JSON.parse(user.encryptedRecoveryCodes)
             index = codes.indexOf(parseInt req.body.authcode)
             if index is -1 # invalid code
                 next makeError 401, 'error otp invalid code'