Skip to content

Commit

Permalink
Remove grace period (#506)
Browse files Browse the repository at this point in the history
This PR removes the 1-block grace period (i.e., getting rewards even if
you miss the deadline by one block). This doesn't seem it makes any
significant difference now. To see this, you can check the following
Dune query

```
select count(*) from "query_4351957(blockchain='ethereum')" where block_number > block_deadline and block_number > 21509183
```
to see mainnet stats for the past month. Or you can drop the
`block_number > 21509183` constraint and also check other chains.
  • Loading branch information
harisang authored Feb 20, 2025
1 parent 1bb7616 commit 3bb7ab8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion queries/orderbook/barn_batch_rewards.sql
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ reward_data as (
-- scores
winning_score,
case
when block_number is not null and block_number <= block_deadline + 1 then winning_score -- this includes a grace period of one block for settling a batch
when block_number is not null and block_number <= block_deadline then winning_score
else 0
end as observed_score,
reference_score,
Expand Down
2 changes: 1 addition & 1 deletion queries/orderbook/prod_batch_rewards.sql
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ reward_data as (
-- scores
winning_score,
case
when block_number is not null and block_number <= block_deadline + 1 then winning_score -- this includes a grace period of one block for settling a batch
when block_number is not null and block_number <= block_deadline then winning_score
else 0
end as observed_score,
reference_score,
Expand Down

0 comments on commit 3bb7ab8

Please sign in to comment.