Skip to content

Hotfix: Changes to the async initialization sequence, #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephaneSeyvoz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hotfix: Changes to the async initialization sequence, #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ import { Platform } from '@ionic/angular';
import { SplashScreen } from '@ionic-native/splash-screen/ngx';
import { StatusBar } from '@ionic-native/status-bar/ngx';

import { createConnection } from 'typeorm';
import { DbService } from './services/db.service';


@Component({
selector: 'app-root',
templateUrl: 'app.component.html'
Expand All @@ -17,7 +13,6 @@ export class AppComponent {
private platform: Platform,
private splashScreen: SplashScreen,
private statusBar: StatusBar,
private dbService: DbService
) {
this.initializeApp();
}
Expand All @@ -27,7 +22,5 @@ export class AppComponent {
this.statusBar.styleDefault();
this.splashScreen.hide();
});

await this.dbService.ready();
}
}
5 changes: 4 additions & 1 deletion src/app/pages/home/home.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { getRepository, Repository } from 'typeorm';
import { Post } from 'src/app/entities/post';
import { Category } from 'src/app/entities/category';
import { Author } from 'src/app/entities/author';
import { DbService } from 'src/app/services/db.service';

@Component({
selector: 'app-home',
Expand All @@ -14,13 +15,15 @@ export class HomePage implements OnInit {
savedPost: boolean = false;
loadedPost: Post = null;

constructor() { }
constructor(private dbService: DbService) { }

ngOnInit() {
this.runDemo();
}

async runDemo() {
await this.dbService.ready();

const category1 = new Category();
category1.name = "TypeScript";

Expand Down
13 changes: 2 additions & 11 deletions src/app/services/db.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,8 @@ export class DbService {
constructor(private platform: Platform) { }

async ready() {
try {

await getConnection();

} catch (ex) {

// console.log('Connection not established!', ex);

await this.createConnection();

}
await this.platform.ready();
await this.createConnection();
}

private createConnection(): Promise<Connection> {
Expand Down