-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase e2e stability #419
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 15 15
Lines 744 744
=======================================
Hits 743 743
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks like things are much more stable now: https://github.com/cosmos/solidity-ibc-eureka/actions/runs/13965649544 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Left some questions
func retryConfig() grpc.DialOption { | ||
policy := `{ | ||
"methodConfig": [{ | ||
"name": [{}], | ||
"retryPolicy": { | ||
"MaxAttempts": 4, | ||
"InitialBackoff": ".01s", | ||
"MaxBackoff": ".01s", | ||
"BackoffMultiplier": 1.0, | ||
"RetryableStatusCodes": [ | ||
"CANCELLED", | ||
"UNKNOWN", | ||
"DEADLINE_EXCEEDED", | ||
"NOT_FOUND", | ||
"ALREADY_EXISTS", | ||
"PERMISSION_DENIED", | ||
"RESOURCE_EXHAUSTED", | ||
"FAILED_PRECONDITION", | ||
"ABORTED", | ||
"OUT_OF_RANGE", | ||
"UNIMPLEMENTED", | ||
"INTERNAL", | ||
"UNAVAILABLE", | ||
"DATA_LOSS", | ||
"UNAUTHENTICATED" | ||
] | ||
} | ||
}] | ||
}` | ||
|
||
return grpc.WithDefaultServiceConfig(policy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to create this in a type safe way or with a builder. (Not that I think we should build one, but asking if grpc already has a builder or something similar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good question. I'll check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem like this exists in the go version of the library :/
@@ -102,7 +102,7 @@ func (e *Ethereum) BroadcastTx(ctx context.Context, userKey *ecdsa.PrivateKey, g | |||
|
|||
func (e Ethereum) ForgeScript(deployer *ecdsa.PrivateKey, solidityContract string, args ...string) ([]byte, error) { | |||
args = append(args, "script", "--rpc-url", e.RPC, "--private-key", | |||
hex.EncodeToString(deployer.D.Bytes()), "--broadcast", | |||
hex.EncodeToString(crypto.FromECDSA(deployer)), "--broadcast", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, curious if you know why it was less stable before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100%, but there is a different handling of the private key bytes (something about fixed sized buffers and whatnot). But this seems to be the correct way, at least.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.