fix: use nanoseconds instead of seconds in sp1 light client #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 14 14
Lines 740 744 +4
=======================================
+ Hits 739 743 +4
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gjermundgaraba
approved these changes
Mar 15, 2025
| function _validateClientStateAndTime( | ||
| IICS07TendermintMsgs.ClientState memory publicClientState, | ||
| uint64 time | ||
| uint128 time |
There was a problem hiding this comment.
why not uint256? Seems like we are using that elsewhere here
There was a problem hiding this comment.
rust returns nanos as u128. I think this is a nice reminder to us that this field is a nanos. Making us less likely to confuse.
| /// @param root commitment root (i.e app hash) | ||
| /// @param nextValidatorsHash next validators hash | ||
| struct ConsensusState { | ||
| uint64 timestamp; | ||
| uint128 timestamp; |
There was a problem hiding this comment.
Not gonna write on the others, but any reason we mix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
zellic audit issue
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.