Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: remove TrustedSyncCommittee #398

Merged
merged 20 commits into from
Mar 18, 2025

Conversation

mconcat
Copy link
Collaborator

@mconcat mconcat commented Mar 12, 2025

Description

closes: #386
closes: #385


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (08653c0) to head (a32d2ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         744      744           
=======================================
  Hits          743      743           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gjermundgaraba gjermundgaraba marked this pull request as ready for review March 17, 2025 15:36
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just made a couple improvement suggestions.

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but I made some substantial refactors while still respecting the sync-protocol. So it might be good to give it another review @gjermundgaraba @mconcat

@srdtrk srdtrk changed the title imp: remove TrustedSyncCommitte imp: remove TrustedSyncCommittee Mar 17, 2025
@gjermundgaraba gjermundgaraba merged commit 67eeb10 into main Mar 18, 2025
63 checks passed
@gjermundgaraba gjermundgaraba deleted the feature/remove-trusted-sync-committe branch March 18, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TrustedSyncCommittee Ensure that consensus state updates always write to the correct slot
3 participants