Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: removed alloy-trie and refactored verify_membership #391

Merged
merged 14 commits into from
Mar 12, 2025

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Mar 11, 2025

Description

closes: #390
closes: #396
closes: #397


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (591e0a6) to head (cf034cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         731      731           
=======================================
  Hits          730      730           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srdtrk srdtrk marked this pull request as ready for review March 12, 2025 08:59
@srdtrk srdtrk requested a review from gjermundgaraba as a code owner March 12, 2025 08:59
@srdtrk srdtrk changed the title imp: remove alloy-trie and unused code imp: remove alloy-trie and refactor verify_membership Mar 12, 2025
@srdtrk srdtrk changed the title imp: remove alloy-trie and refactor verify_membership imp: removed alloy-trie and refactored verify_membership Mar 12, 2025
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Something we could add later is also some more unit tests that verify that the proofs work as expected (fail when they should and so on)

@srdtrk srdtrk merged commit e929d43 into main Mar 12, 2025
63 checks passed
@srdtrk srdtrk deleted the serdar/xxx-remove-encode branch March 12, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants