Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable multiple pausers and unpausers #388

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Zygimantass
Copy link
Contributor

Description

This PR enables the ICS20Transfer contracts to initialize with multiple pausers and unpausers.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (a769748) to head (e376bcc).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           zygis/admin-only-pause     #388   +/-   ##
=======================================================
  Coverage                   99.86%   99.86%           
=======================================================
  Files                          14       14           
  Lines                         740      740           
=======================================================
  Hits                          739      739           
  Misses                          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gjermundgaraba
Copy link
Contributor

gjermundgaraba commented Mar 11, 2025

Actually, we don't want to have all this complex initialization stuff. Rather the deployment procedure should be that we set it up with a simple wallet and then give all the permissions as separate actions (including the deployer to set set the correct admin). This can all still be done in a script though.

In fact, if anything we would probably want to remove more from the initializer function to make it simpler.

Base automatically changed from zygis/admin-only-pause to main March 12, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants