-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable multiple pausers and unpausers #388
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: srdtrk <[email protected]>
Co-authored-by: srdtrk <[email protected]>
This reverts commit b5c6526.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## zygis/admin-only-pause #388 +/- ##
=======================================================
Coverage 99.86% 99.86%
=======================================================
Files 14 14
Lines 740 740
=======================================================
Hits 739 739
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Actually, we don't want to have all this complex initialization stuff. Rather the deployment procedure should be that we set it up with a simple wallet and then give all the permissions as separate actions (including the deployer to set set the correct admin). This can all still be done in a script though. In fact, if anything we would probably want to remove more from the initializer function to make it simpler. |
Description
This PR enables the ICS20Transfer contracts to initialize with multiple pausers and unpausers.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.