-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): failed receive after timeout test case #350
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 14 14
Lines 744 744
=======================================
Hits 743 743
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the additions to the tests are reasonable, but I think the purpose of referenced test scenarios are to test a receive that failed on the counterparty, and you then try to time out the packet. We can check this more tomorrow, but I think in general we need to specify the scenarios a bit more, because this is not obvious (even to me).
For reference, I think the scenario to test is:
- Transfer from Chain A
- Transfer fails on Chain B (i.e. a failure ack is written)
- Wait until timeout period has passed
- Try to time out the packet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! :)
Left a couple of minor comments/questions
…lidity-ibc-eureka into e2e-test-eth-timeout-no-effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additions look good. Can you add this to the timeout test in relayer_test.go
?
…lidity-ibc-eureka into e2e-test-eth-timeout-no-effect
…lidity-ibc-eureka into e2e-test-eth-timeout-no-effect
…lidity-ibc-eureka into e2e-test-eth-timeout-no-effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now. After my last 2 comments are addressed, you can merge this directly
Description
ref: #313
Implements
Failed receive after timeout on Ethereum
Failed receive after timeout on Cosmos
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.