Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): failed receive after timeout test case #350

Merged
merged 23 commits into from
Mar 18, 2025

Conversation

mconcat
Copy link
Collaborator

@mconcat mconcat commented Feb 28, 2025

Description

ref: #313

Implements

  • Failed receive after timeout on Ethereum
  • Failed receive after timeout on Cosmos

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@mconcat mconcat changed the title feat(tests/e2e feat(tests/e2e): Failed receive on timeout test case Feb 28, 2025
@mconcat mconcat marked this pull request as ready for review February 28, 2025 15:35
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (c960595) to head (e73e053).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         744      744           
=======================================
  Hits          743      743           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the additions to the tests are reasonable, but I think the purpose of referenced test scenarios are to test a receive that failed on the counterparty, and you then try to time out the packet. We can check this more tomorrow, but I think in general we need to specify the scenarios a bit more, because this is not obvious (even to me).

For reference, I think the scenario to test is:

  1. Transfer from Chain A
  2. Transfer fails on Chain B (i.e. a failure ack is written)
  3. Wait until timeout period has passed
  4. Try to time out the packet.

Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! :)

Left a couple of minor comments/questions

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions look good. Can you add this to the timeout test in relayer_test.go?

@gjermundgaraba gjermundgaraba requested a review from srdtrk March 13, 2025 09:48
@srdtrk srdtrk changed the title feat(tests/e2e): Failed receive on timeout test case test(e2e): failed receive after timeout test case Mar 14, 2025
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now. After my last 2 comments are addressed, you can merge this directly

@srdtrk srdtrk merged commit 0480374 into main Mar 18, 2025
57 checks passed
@srdtrk srdtrk deleted the e2e-test-eth-timeout-no-effect branch March 18, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants