remove some Jasmine specific code from tests #1809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynst
force-pushed
the
jasmine-removal-prep
branch
from
c3383b8 to
286373f
Compare
it's present in all supported environments.
dynst
force-pushed
the
jasmine-removal-prep
branch
3 times, most recently
from
422bb8e to
b15a071
Compare
dynst
force-pushed
the
jasmine-removal-prep
branch
from
6e34a71 to
b7efa10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fail()andpending()globals exist in no other testing suite and are completely non-portable idioms.There's good reason others didn't copy them, dynamically deciding whether or not to skip every individual test only after each one has already started executing is a bit...barbaric.