transpile to ESM with tsdown #1804
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no ChunkLoadError is possible then.
Effectively synonymous with nodenext.
already implied by tsconfig compilerOptions.module=node20
can't omit a file extension if cosmjs becomes ESM. that only works if transpiled to CJS.
dynst
force-pushed
the
tsdown
branch
4 times, most recently
from
79f7e80 to
4fe6f91
Compare
dynst
force-pushed
the
tsdown
branch
17 times, most recently
from
603753e to
9205440
Compare
dist/ is the universal convention for actually distributing the library. build/ for temporary build artifacts for tests.
it's still a peer dependency of an eslint plugin in the root, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1004
Blocked on
#1758
#1785
#1805
And possibly a hilarious interaction with using yarn pnp instead of
node_modules/.https://yarnpkg.com/getting-started/qa#does-yarn-support-esm
yarnpkg/berry#4044 (comment)