Skip to content

simplify eslint flat config #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

simplify eslint flat config #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4c8eec
simplify typescript flat config
dynst Aug 7, 2025
b0f0ac3
simplify import plugin flat config
dynst Aug 7, 2025
d8cc2ef
use eslint-plugin-import's typescript resolver in all files
dynst Aug 7, 2025
22a8b30
re-enable import/no-cycle
dynst Aug 7, 2025
12a138d
silence import/no-named-as-default and save some bundle size
dynst Aug 7, 2025
2eb8073
yarn remove @eslint/compat
dynst Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions .yarn/cache/@eslint-compat-npm-1.3.1-41a44c7960-8dfcea5ecb.zip
View file
Open in desktop

This file was deleted.

30 changes: 9 additions & 21 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { fixupPluginRules } from "@eslint/compat";
import js from "@eslint/js";
import typescriptEslint from "@typescript-eslint/eslint-plugin";
import tsParser from "@typescript-eslint/parser";
import importt from "eslint-plugin-import";
import prettier from "eslint-plugin-prettier/recommended";
import simpleImportSort from "eslint-plugin-simple-import-sort";
Expand All @@ -13,11 +11,10 @@ export default [
},
js.configs.recommended,
prettier,
// importt.flatConfigs.recommended,
importt.flatConfigs.recommended,
{
plugins: {
"simple-import-sort": simpleImportSort,
import: fixupPluginRules(importt),
},

languageOptions: {
Expand All @@ -30,6 +27,12 @@ export default [
ecmaVersion: 2022,
},

settings: {
"import/resolver": {
typescript: {},
},
},

rules: {
curly: ["warn", "multi-line", "consistent"],
"no-bitwise": "warn",
Expand All @@ -55,41 +58,26 @@ export default [
},
],

"import/no-cycle": "off",
"simple-import-sort/imports": "warn",
"simple-import-sort/exports": "warn",
},
},
{ files: ["**/*.ts"], ...importt.flatConfigs.typescript },
...typescriptEslint.configs["flat/strict-type-checked"].map((c) => ({ files: ["**/*.ts"], ...c })),
{
files: ["**/*.ts"],

plugins: {
"@typescript-eslint": fixupPluginRules(typescriptEslint),
},

languageOptions: {
parser: tsParser,
ecmaVersion: 2022,

parserOptions: {
project: true,
},
},

settings: {
"import/resolver": {
typescript: {},
},
},

rules: {
"no-shadow": "off",
"no-unused-vars": "off",
...typescriptEslint.configs["flat/strict-type-checked"].reduce(
(obj, c) => Object.assign(obj, c.rules),
{},
),
...importt.flatConfigs.typescript.rules,

// lints from 'strict-type-checked' config
"@typescript-eslint/no-deprecated": "off",
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"@cosmjs/encoding": "workspace:^",
"@cosmjs/proto-signing": "workspace:^",
"@cosmjs/stargate": "workspace:^",
"@eslint/compat": "^1.3.1",
"@eslint/eslintrc": "^3.3.1",
"@eslint/js": "^8.57.1",
"@typescript-eslint/eslint-plugin": "^8.39.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/ledger-amino/src/ledgerconnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { assert } from "@cosmjs/utils";
import Transport from "@ledgerhq/hw-transport";
// eslint-disable-next-line @typescript-eslint/naming-convention
import CosmosApp from "@zondax/ledger-cosmos-js";
import semver from "semver";
import semverGte from "semver/functions/gte.js";

const cosmosHdPath = makeCosmoshubPath(0);
const cosmosBech32Prefix = "cosmos";
Expand Down Expand Up @@ -125,7 +125,7 @@ export class LedgerConnector {

private async verifyAppVersion(): Promise<void> {
const version = await this.getCosmosAppVersion();
if (!semver.gte(version, this.minLedgerAppVersion)) {
if (!semverGte(version, this.minLedgerAppVersion)) {
throw new Error(
`Outdated version: Please update ${this.ledgerAppName} Ledger App to the latest version.`,
);
Expand Down
13 changes: 0 additions & 13 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,18 +811,6 @@ __metadata:
languageName: node
linkType: hard

"@eslint/compat@npm:^1.3.1":
version: 1.3.1
resolution: "@eslint/compat@npm:1.3.1"
peerDependencies:
eslint: ^8.40 || 9
peerDependenciesMeta:
eslint:
optional: true
checksum: 10c0/8dfcea5ecb854111f9c0acc23a469e0a25cdaddceb5fb40c47988c247d6e32ec199bcd00f1b8ba9ed779228526552703c4b74948169e78b78b5fd814e04b042b
languageName: node
linkType: hard

"@eslint/eslintrc@npm:^2.1.4":
version: 2.1.4
resolution: "@eslint/eslintrc@npm:2.1.4"
Expand Down Expand Up @@ -3039,7 +3027,6 @@ __metadata:
"@cosmjs/encoding": "workspace:^"
"@cosmjs/proto-signing": "workspace:^"
"@cosmjs/stargate": "workspace:^"
"@eslint/compat": "npm:^1.3.1"
"@eslint/eslintrc": "npm:^3.3.1"
"@eslint/js": "npm:^8.57.1"
"@typescript-eslint/eslint-plugin": "npm:^8.39.0"
Expand Down