-
Notifications
You must be signed in to change notification settings - Fork 399
migrate to @scure/base for base64 & bech32 encoding #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CircleCI output
|
Thanks. LFS budget was fixed now. I am happy for the new implementation. But can we do that without changing the types of CosmJS interfaces? Is it possible to use bech32 decoding without knowing the prefix? |
For a backwards compatible 0.33.2 release, existing TypeScript code can't break if it was expecting a The new return type of the decode function and some address-getters doesn't force users to change anything, but it does give them the choice to take advantage of the new type to enforce more compile-time constraints (statically ensuring this string is a valid address) in their codebase. And if you mean, is it possible to use this library's decode function without casting |
I am trying to use @scure/base without changing public interfaces. But hitting some issues. See paulmillr/scure-base#43 |
If no breaking type interface changes ever happen in CosmJS, why are there so many semver-incompatible versions (0.33, 0.34, 0.35), which indicate breaking changes? |
Return types are narrowed in a way that's still backwards-compatible.
ad4a5e0
to
6350748
Compare
TypeScript return types are narrowed in a way that's still backwards-compatible.