Skip to content

Add folder view component #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Carifio24
Copy link
Member

This PR adds an implementation of the folder view component. This is an expanded version of the component that we've used in previous stories (the Rubin story in particular). The main items of note are:

  • We've never really used the folder navigation piece of this before, and so while testing it out I unsurprisingly found a few issues. This component has those resolved. The Storybook story for the component in this PR uses the same folder as the WWT webclient so one can easily see this functionality at work.
  • This component has built-in default content for the folder items, but in case we want to tweak what the item display looks like for a given story, the item content is now in an item slot. The downside to this is that the slot content will need to re-implement the selection handling itself. I would've liked to push the event handlers up to the slot container, but this could potentially interfere with the functionality of whatever content one puts into the item slot.
  • As a convenience, the root folder can now be specified as a URL instead of passing in a Folder object, if one wants. If managing the folder instance isn't necessary in the parent component, this can help reduce overhead on that side.

There are still some CSS issues to work out here, but I think the internals of this are in good shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant