Skip to content

Fix icon button disabled state #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

johnarban
Copy link
Contributor

Implement a disabled state.

The disabled state can be styled using

.icon-wrapper[aria-disabled=true] {
    // styles
  }

@Carifio24
Copy link
Member

Looks good to me. I added a default value for this flag to the Storybook story (and gave that story a bit of styling so that the disabled state is evident).

Only thing I'm wondering about is whether we want the tooltip to still be active when the button is disabled?

@Carifio24
Copy link
Member

I really like the cursor style update. I have one question about the tooltip styling - what is the intended color to get for the disabled styling? For me the disabled tooltip now looks like the image below, which is kinda hard to read.

Screenshot from 2025-06-19 11-09-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants